pkg/aiusechat/openai/openai-convertmessage.go (2)

393-399: Consider extracting hash generation to a helper function.

The deterministic hashing logic works correctly for prompt caching. However, this same pattern is duplicated for directory listings (lines 422-428).

Consider extracting to a helper function:

// computeDeterministicSuffix generates an 8-character deterministic suffix
// from content and name using SHA-256 hashing for prompt caching
func computeDeterministicSuffix(content, name string) string {
	hasher := sha256.New()
	hasher.Write([]byte(content))
	hasher.Write([]byte(name))
	hash := hasher.Sum(nil)
	return hex.EncodeToString(hash)[:8]
}

Then use it as:

-		// Generate deterministic suffix from content hash for prompt caching
-		hasher := sha256.New()
-		hasher.Write([]byte(textContent))
-		hasher.Write([]byte(fileName))
-		hash := hasher.Sum(nil)
-		deterministicSuffix := hex.EncodeToString(hash)[:8]
+		// Generate deterministic suffix from content hash for prompt caching
+		deterministicSuffix := computeDeterministicSuffix(textContent, fileName)

Note on collision risk: The 8-character truncation (32 bits) provides ~4 billion unique values. This should be sufficient for typical conversation contexts, but consider increasing to 12-16 characters if you observe collisions in production.

---

422-428: Duplicate hashing logic - use the same helper function.

This is identical to the text file hashing logic above (lines 393-399). If you extract the helper function suggested in the previous comment, apply it here as well:

-		// Generate deterministic suffix from content hash for prompt caching
-		hasher := sha256.New()
-		hasher.Write([]byte(jsonContent))
-		hasher.Write([]byte(directoryName))
-		hash := hasher.Sum(nil)
-		deterministicSuffix := hex.EncodeToString(hash)[:8]
+		// Generate deterministic suffix from content hash for prompt caching
+		deterministicSuffix := computeDeterministicSuffix(jsonContent, directoryName)

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro